CLI panics upon EPIPE

[taspelund]

Component

• CLI
• SDK
• Something else
• Not sure

What was the expected behaviour

CLI should gracefully handle EPIPE, e.g. when piping the output of oxide into a typo'd command.

What is the current behaviour and what actions did you take to get there

Running an oxide command and piping it into a failed command results in a panic.

➜  Downloads ./oxide ping | a
zsh: command not found: a
thread 'tokio-runtime-worker' panicked at library/std/src/io/stdio.rs:1021:9:
failed printing to stdout: Broken pipe (os error 32)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at cli/src/main.rs:102:10:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(9), ...)

Meanwhile this works just fine so long as the CLI doesn't fail to write to its stdout fd:

➜  Downloads ./oxide ping | grep .
{
  "status": "ok"
}

CLI or SDK version

0.6.2+20240710.0

Operating system

MacOS 14.5

Anything else you would like to add?

➜  Downloads ./oxide version
Oxide CLI 0.6.2+20240710.0
Built from commit: 1a1abdbf03dfc18cbb7c1ccef60833a1ae406bc8
Oxide API: 20240710.0

[david-crespo]

I believe this is fixed by #746. The release build is built off 1a1abdb, which is a patch commit not on main, but its parent is 040f1b0, the commit before #746 was merged.

[taspelund]

I didn't see #746 before filing this, but I'm still seeing the panic when building from main -> HEAD and piping into an invalid command. piping into head -1 works, but piping into a non-existent command (e.g. a) still panics at the same spot:

➜  oxide.rs git:(main) ./target/debug/oxide version | head -1
Oxide CLI 0.6.1+20240710.0
➜  oxide.rs git:(main) ./target/debug/oxide version | a
zsh: command not found: a
thread 'tokio-runtime-worker' panicked at library/std/src/io/stdio.rs:1021:9:
failed printing to stdout: Broken pipe (os error 32)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at cli/src/main.rs:105:10:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(9), ...)