fix: support versioned nexus openapi specification files #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Closes #353. |
Updated the generator binary to support versioned Nexus OpenAPI specification files, as introduced in oxidecomputer/omicron#9430. Closes SSE-129.
sudomateo
force-pushed
the
sudomateo/qllpxrxnznzs
branch
from
aa27d6f to
dd9803f
Compare
Collaborator
Author
|
I had the logic done already from yesterday but I used Amp to clean it up: https://ampcode.com/threads/T-019b044d-fa43-714c-b088-ffee81778d87 |
jmcarp
reviewed
Dec 9, 2025
jmcarp
reviewed
Dec 9, 2025
jmcarp
reviewed
Dec 9, 2025
jmcarp
reviewed
Dec 9, 2025
jmcarp
approved these changes
Dec 9, 2025
Contributor
jmcarp
left a comment
jmcarp
left a comment
There was a problem hiding this comment.
Looks good! I have minor nits and questions only, so merge at will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the generator binary to support versioned Nexus OpenAPI specification files, as introduced in oxidecomputer/omicron#9430.
Closes SSE-129.