Skip to content

Do not allow snapshots of read-only disks#9857

Merged
jmpesp merged 3 commits intooxidecomputer:mainfrom
jmpesp:do_not_snapshot_read_only_disk
Feb 12, 2026
Merged

Do not allow snapshots of read-only disks#9857
jmpesp merged 3 commits intooxidecomputer:mainfrom
jmpesp:do_not_snapshot_read_only_disk

Conversation

@jmpesp
Copy link
Contributor

@jmpesp jmpesp commented Feb 12, 2026

No description provided.

@leftwo leftwo added this to the 18 milestone Feb 12, 2026
@leftwo
Copy link
Contributor

leftwo commented Feb 12, 2026

Fix for: #9855

@jmpesp jmpesp linked an issue Feb 12, 2026 that may be closed by this pull request
@david-crespo
Copy link
Contributor

Doesn't need to be in this PR if it'll delay this getting merged, but there should be an integration test for this.

@jmpesp
Copy link
Contributor Author

jmpesp commented Feb 12, 2026

Doesn't need to be in this PR if it'll delay this getting merged, but there should be an integration test for this.

Pushed - the original push was at midnight so I deferred writing a test, but you're right that this should have one.

Copy link
Contributor

@leftwo leftwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the limit, we may want to allow snapshots of read-only disks. If the only way to export a volume is via a snapshot, then it seems unsporting to require users to keep around the source snapshot for a read only disk in case they decide they want to export it. Or, worse, not know they needed to and now it's too late.

But, for now, our underlying implementation does not support it, so best we turn it off.

@jmpesp jmpesp enabled auto-merge (squash) February 12, 2026 16:41
@jmpesp jmpesp merged commit b352ffb into oxidecomputer:main Feb 12, 2026
16 checks passed
@jmpesp jmpesp deleted the do_not_snapshot_read_only_disk branch February 12, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snapshots of read only disks take all available memory

3 participants