incorporate maghemite #533 #9449
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trey Aspelund <[email protected]>
maghemite #533 adds impl PartialEq<rdb_types::Prefix> for oxnet::IpNet, which caused some preexisting type inferences to no longer be resolved unambiguously (now there are multiple PartialEq<T> for oxnet::IpNet). This updates these spots to be explicit about the types being compared. Signed-off-by: Trey Aspelund <[email protected]>
| &self, | ||
| opctx: &OpContext, | ||
| sel: ¶ms::BgpRouteSelector, | ||
| _sel: ¶ms::BgpRouteSelector, |
Contributor
There was a problem hiding this comment.
If we're no longer querying imported routes by ASN, we should propagate that up through the omicron API function networking_bgp_imported_routes_ipv4 so users of the API don't have to specify an ASN that's no longer used for anything. Then we can remove the sel parameter.
Contributor
Author
There was a problem hiding this comment.
Agreed. However, the change I'm envisioning would be to deprecate the old endpoint (/v1/system/networking/bgp-routes-ipv4) and introduce a new endpoint that will not be specific to BGP or IP version (e.g. /v1/system/networking/routes). I'm not sure exactly what this will look like yet from a Nexus API standpoint, so I put this in as a placeholder for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.