Add queries to allocate external IPv6 addresses #9282
Draft
+1,371
−503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
external-ipv6-address-queries
branch
from
23b7634 to
4f1b708
Compare
- Rewrite the `NextExternalIp` query to allow IPv6 address allocations. This uses queries more like the existing "next-item" queries based on a self-join, where we're joining the existing address with those addresses plus-one, and taking the first free one. - Handle a few more failure-cases from the new query to ensure we detect address exhaustion, reallocation, and so on. All the existing tests continue to pass. - Add expectorate / explain "tests" for the new queries - Add a few new tests, some specifically for IPv6 address allocations and the details / corner cases of the new query structure - Closes #9245
bnaecker
force-pushed
the
external-ipv6-address-queries
branch
from
4f1b708 to
dc77103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextExternalIpquery to allow IPv6 address allocations. This uses queries more like the existing "next-item" queries based on a self-join, where we're joining the existing address with those addresses plus-one, and taking the first free one.