[reconfigurator] Fix planner RoT active slot bug #8893
Conversation
| expected_pending_persistent_boot_preference, | ||
| expected_transient_boot_preference, | ||
| }) => { | ||
| let active_caboose_which = match &expected_active_slot.slot { |
There was a problem hiding this comment.
I'm a little surprised this didn't break some (incorrect) tests - can we add a test somewhere that only passes with this change? How did the reconfiguator-cli target-release test pass before?
There was a problem hiding this comment.
Franky, I'm surprised too. But yeah! I'll add a test, good call
|
So, I tried to test this case within the RoT planner tests but failed. I'm not entirely sure I can force this test case here 🤔 Next week I'll attempt to test via the reconfigurator CLI tests 🤞 |
|
I did manage to improve the tests for the RoT so I added the case where an update is configured for a different active RoT slot, so I'll keep that |
|
Turns out the RoT active slot extension was on the wrong SP type. The test works fine. Will update the reconfigurator CLI tests in a follow up PR |
3 participants
Fixes a bug where the planner was using the expected active slot as the found active slot for doing status checks.
Closes: #8887