Skip to content

api_versions! should make public Semver consts #8322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

api_versions! should make public Semver consts #8322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions dev-tools/openapi-manager/types/src/versions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ impl SupportedVersions {
/// these, equivalent to:
///
/// ```
/// const VERSION_ADD_FOOBAR_OPERATION: semver::Version =
/// pub const VERSION_ADD_FOOBAR_OPERATION: semver::Version =
/// semver::Version::new(2, 0, 0);
/// const VERSION_INITIAL: semver::Version =
/// pub const VERSION_INITIAL: semver::Version =
/// semver::Version::new(1, 0, 0);
/// ```
///
Expand Down Expand Up @@ -147,7 +147,7 @@ macro_rules! api_versions {
) ),* $(,)? ] ) => {
openapi_manager_types::paste! {
$(
const [<VERSION_ $name>]: semver::Version =
pub const [<VERSION_ $name>]: semver::Version =
semver::Version::new($major, 0, 0);
)*

Expand Down Expand Up @@ -178,7 +178,7 @@ macro_rules! api_versions_picky {
) ),* $(,)? ] ) => {
openapi_manager_types::paste! {
$(
const [<VERSION_ $name>]: semver::Version =
pub const [<VERSION_ $name>]: semver::Version =
semver::Version::new($major, $minor, $patch);
)*

Expand Down
2 changes: 1 addition & 1 deletion dns-server/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ pub async fn start_servers(
"api-version"
.parse::<http::header::HeaderName>()
.expect("api-version is a valid header name"),
semver::Version::new(2, 0, 0),
dns_server_api::VERSION_SOA_AND_NS,
),
)))
.start()
Expand Down
1 change: 1 addition & 0 deletions internal-dns/resolver/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ anyhow.workspace = true
assert_matches.workspace = true
dropshot.workspace = true
dns-server.workspace = true
dns-server-api.workspace = true
dns-service-client.workspace = true
expectorate.workspace = true
omicron-test-utils.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion internal-dns/resolver/src/resolver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,7 @@ mod test {
"api-version"
.parse::<reqwest::header::HeaderName>()
.expect("api-version is a valid header name"),
semver::Version::new(2, 0, 0),
dns_server_api::VERSION_SOA_AND_NS,
),
)))
.start()
Expand Down
Loading