cargo test --no-fail-fast in CI #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
I usually only care if I broke anything (so I don't mind the fail-fast behavior). But I'll usually run it locally anyway until it works. I don't really care either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an initial version of #581, I forgot to update the sled agent OpenAPI JSON, but I did not see a test failure in CI that would have made that obvious because
cargo testby default bails on the remaining targets if it gets failures in one target. It took a bunch of work to figure out the issue and fix it in #589.--no-fail-fast, which turns off that bailing behavior, seems like an obvious improvement. The longest it can make the tests take is however long they take when they pass.