[MGS] Flesh out SpState information #2287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjstone
approved these changes
Feb 2, 2023
Contributor
andrewjstone
left a comment
andrewjstone
left a comment
There was a problem hiding this comment.
I'm very excited to see this plumbing make it's way north.
| JsonSchema, | ||
| )] | ||
| #[serde(tag = "state", rename_all = "snake_case")] | ||
| pub enum SpState { |
Contributor
There was a problem hiding this comment.
Oh hell yes! This is stuff wicket craves!
jgallagher
force-pushed
the
mgs-clear-component-status
branch
from
10fd6b9 to
6206366
Compare
Adds serial number/model/revision, hubris image information, and RoT information.
jgallagher
force-pushed
the
mgs-flesh-out-state
branch
from
1880229 to
78207a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds serial number/model/revision, hubris image information, and RoT information.
Builds on #2286 and should be merged after it.
Fixes https://github.com/oxidecomputer/minimum-upgradable-product/issues/40.