gateway-messages: Add variants for SP auxflash updates #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftwo
pushed a commit
that referenced
this pull request
Sep 23, 2025
Crucible changes are: update to latest `vergen` (#1770) Update rand dependencies, and fallout from that. (#1764) [crucible-downstairs] migrate to API traits (#1768) [crucible-agent] migrate to API trait (#1766) [crucible-pantry] migrate to API trait (#1767) Add back job delays in the downstairs with the --lossy flag (#1761) Propolis changes are: Crucible update plus a few other dependency changes. (#948) [2/n] [propolis-server] switch to API trait (#946) [1/n] add a temporary indent to propolis server APIs (#945) Handle Intel CPUID leaves 4 and 18h, specialize CPUID for VM shape (#941) Increase viona receive queue length to 2048 (#935) Expand viona header pad to account for options (#937) fix linux p9fs multi message reads (#932) add a D script to report VMs' CPUID queries (#934) Update GH actions Re-enable viona packet data loaning
leftwo
added a commit
that referenced
this pull request
Sep 26, 2025
Crucible changes are: update to latest `vergen` (#1770) Update rand dependencies, and fallout from that. (#1764) [crucible-downstairs] migrate to API traits (#1768) [crucible-agent] migrate to API trait (#1766) [crucible-pantry] migrate to API trait (#1767) Add back job delays in the downstairs with the --lossy flag (#1761) Propolis changes are: Crucible update plus a few other dependency changes. (#948) [2/n] [propolis-server] switch to API trait (#946) [1/n] add a temporary indent to propolis server APIs (#945) Handle Intel CPUID leaves 4 and 18h, specialize CPUID for VM shape (#941) Increase viona receive queue length to 2048 (#935) Expand viona header pad to account for options (#937) fix linux p9fs multi message reads (#932) add a D script to report VMs' CPUID queries (#934) Update GH actions Re-enable viona packet data loaning --------- Co-authored-by: Alan Hanson <[email protected]> Co-authored-by: Sean Klein <[email protected]> Co-authored-by: Rain <[email protected]> Co-authored-by: John Gallagher <[email protected]> Co-authored-by: iliana etaoin <[email protected]> Co-authored-by: Sean Klein <[email protected]> Co-authored-by: Alex Plotnick <[email protected]> Co-authored-by: David Pacheco <[email protected]> Co-authored-by: Andrew J. Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are mostly mechanical; the actual implementation will come in a followup PR. Changes include:
UpdatePreparemessage has been renamedComponentUpdatePrepare, and there is a newSpUpdatePreparethat includes auxflash-specific information (the chck value and the size)UpdateStatushas two new cases:Failed(previously we'd return aResponseError, but that felt wrong - we can successfully respond that an update has failed)SpUpdateAuxFlashChckScan- this is only valid for SP updates, and is the state we have to see before starting to send data. It returns whether or not the SP already has the auxflash we want to send it. (If the update has no auxflash at all, this state is skipped.)The bulk of the PR is just dealing with the fallout of these - adding new arms to matches, etc.