Remove trust quorum shares from sled agent requests #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary motivator behind this was to avoid accidentally logging all the trust quorum shares from RSS, so we include some relatively heavy-handed machinery to minimize the chances of reintroducing that in the future.
andrewjstone
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Thanks for fixing this security hole and putting in some safeguards @jgallagher. Logged secret shares are the new logged passwords :)
| fn danger_serialize_as_toml(&self) -> Result<String, toml::ser::Error> { | ||
| #[derive(Serialize)] | ||
| #[serde(remote = "PersistentSledAgentRequest")] | ||
| struct PersistentSledAgentRequestDef<'a> { |
There was a problem hiding this comment.
What does the Def suffix stand for?
There was a problem hiding this comment.
"Definition", I think; this is from https://serde.rs/remote-derive.html. In this case we don't need remote derive because we control the original type, but we choose to use it because the original type intentionally doesn't derive Serialize.
There was a problem hiding this comment.
Ah, cool it comes from serde example. Stick with it then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivator behind this was to avoid accidentally logging all the trust quorum shares from RSS, so we include some relatively heavy-handed machinery to minimize the chances of reintroducing that in the future.
There are two structural changes here that I believe are correct regardless of the logging issue:
SledAgentRequest. It's still sent alongsideSledAgentRequestwhen RSS initializes a remote sled, but not as part of the same structure.If you think the avoidance of
#[derive(Serialize)]and the use of thedanger_serialize_*functions is overboard, I'm certainly not wedded to them, but I think they're a reasonable starting point for discussion in terms of avoiding accidentally reintroducing leakage of the shares.