More accurate error messages when setting target release after mupdate - #11018
Open
jgallagher wants to merge 4 commits into
Open
More accurate error messages when setting target release after mupdate#11018jgallagher wants to merge 4 commits into
jgallagher wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #10921 (comment):
We now have an explicit error variant for "we're trying to recover a mupdate but found multiple different versions of software on the rack", which includes all the unexpected versions we found.
This PR should only be changing error messages, no behavior, with one small exception for a pathological case: if we somehow attempt to set a target release while our current blueprint has no sleds in it, previously we would have treated that as ok because we didn't find anything on a different version - now we'll return a 500 for "no sleds in the blueprint".