Begin removing/disabling wildcard imports. #1752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiffle
commented
Apr 17, 2024
| pub static CURRENT_TIME: Cell<u64> = Cell::new(0); | ||
| pub static TIMER_SETTING: Cell<(Option<u64>, u32)> = Cell::default(); | ||
| pub static CURRENT_TIME: Cell<u64> = const { Cell::new(0) }; | ||
| pub static TIMER_SETTING: Cell<(Option<u64>, u32)> = const { Cell::new((None, 0)) }; |
There was a problem hiding this comment.
(turns out we're not running clippy on multitimer, so these lines had warnings.)
cbiffle
force-pushed
the
cbiffle/deprecate-wildcard-imports
branch
from
d5f4c0e to
cf46d21
Compare
hawkw
approved these changes
Apr 17, 2024
mkeeter
approved these changes
Apr 17, 2024
cbiffle
force-pushed
the
cbiffle/deprecate-wildcard-imports
branch
5 times, most recently
from
1a0cd30 to
7676a51
Compare
This starts with the "core" code in sys, test, and jefe, and works out
from there.
Any package can opt into this at any time by adding this to its
Cargo.toml:
[lints]
workspace = true
This will also cause it to pick up any future lints we decide on.
cbiffle
force-pushed
the
cbiffle/deprecate-wildcard-imports
branch
from
7676a51 to
b7983ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts with the "core" code in sys, test, and jefe, and works out from there.
Any package can opt into this at any time by adding this to its Cargo.toml:
This will also cause it to pick up any future lints we decide on.