Update asm blocks in workaround for framepointer clobber miscompilation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my opinion, this makes the constraints a _lot_ easier to read, and gets us things like noreturn. (Plus, it moves us off a deprecated feature whose days are numbered.) asm has opinions about trying to use r11. These opinions are misguided: rust-lang/rust#73450 However, we respect them by manually moving values in and out of r11 in the asm sequences.
This completes the sequence of workarounds for: rust-lang/rust#73450 r7 is the frame pointer. asm! cannot reason about clobbers of r7. It tries to statically refuse it, but statically refuses r11 instead. This avoids clobbering r7.
labbott
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wheeeee rust-lang/rust#73450
This should fix things?