Upgrade to tokio 1.0 and hyper 0.14 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dropshot/src/http_util.rs dropshot/src/server.rs dropshot/src/test_util.rs
nshalman
changed the title
ahl
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
This looks good to me. @davepacheco can you merge if you're happy?
|
Thanks for doing this! I went through the changelogs for Bytes, Tokio, and Hyper. It looks basically fine. I'm not a fan of logging when we fail to set socket options and I'm not sure if "hyper no longer emits log records automatically" affects us. Regardless, unless we're going to switch to something else, moving forward here is the right change. Thanks again! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some minor code changes needed to complete the upgrade to tokio 1.0 and hyper 0.14 which I've made here.
Additionally hyper upgrades to bytes 1 and that change seems to be needed here as well.
I fell down this rabbit whole as I was planning to start writing my own service based on dropshot, but haven't written it yet so I don't have any downstream codebases to test against. I got no test failures on my machine, but some were skipped so I figured I'd see what your CI does with this.
Let me know how to rewrite the summary, if you want a squashed branch, etc. or, since I've checked the "Allow edits by maintainers" box, feel free to do with this PR as you wish!
Fixes #60
Duplicate of #66