update to 1.64 and use workspace dependencies

[justinmmott]

currently trybuild does not work properly with workspace defined dependencies. So, serde and proc-macro2 have been left alone in the dropshot/Cargo.toml file. I have opened an issue on the trybuild repo to try and resolve this.

[justinmmott]

currently trybuild does not work properly with workspace defined dependencies. So, serde and proc-macro2 have been left alone in the dropshot/Cargo.toml file. I have opened an issue on the trybuild repo to try and resolve this.

No longer an issue as trybuild was updated

[justinmmott]

dependabot/dependabot-core#5315 seems that this wouldn't fix this issue as some of the test errors have changed slightly

[davepacheco]

@justinmmott Thanks for doing this. I see Renovate also opened a PR to update to 1.64 in #444. We can close that one if we wind up moving forward with this one.

What does using workspace dependencies mean for consumers? Does it mean that consumers must be using 1.64 or newer?

[justinmmott]

@davepacheco Sounds good to me. I'm not sure about what the workspace dependencies will do for customers, I was hoping the change to the rust-toolchain.toml would alleviate any issues with that. Also, #typify/113 has some discussion on the matter as well. However, in this case I don't think that dependabot would be able to make the changes in the .stderr files.

[davepacheco]

I believe rust-toolchain.toml is used only when people clone and build dropshot directly. But if you've got an application (like our own omicron) that uses dropshot, then dropshot's rust-toolchain.toml is not used. We use rust-toolchain in dropshot mainly to communicate (and enforce) that dropshot devs are using a consistent toolchain. Dropshot itself is expected to work with a wider range of Rust versions (though we've never really said what that is, either). I think we'd at least want to make sure our own projects won't break with this change.

[davepacheco]

Ah I see @ahl also called out the dependency on dependabot/dependabot-core#5315 -- that'd apply here too.

[davepacheco]

FYI I went ahead and updated and landed #444 since it seems like there are still some open questions here.

[justinmmott]

Accidentally discard my changes due to trying to merge main into my fork. Didn't realize the ui would even let me do that so didn't look to closely lol. But it's fine because this can be closed as the depandabot change would be able to correctly change this now.

[davepacheco]

Ah okay. For what it's worth I think workspace inheritance is still promising here. I think we just want to make sure it won't break consumers (either by verifying that it doesn't, or by updating the ones we know about and bumping the major rev of this crate).

[justinmmott]

Ah okay. For what it's worth I think workspace inheritance is still promising here. I think we just want to make sure it won't break consumers (either by verifying that it doesn't, or by updating the ones we know about and bumping the major rev of this crate).

Oh I totally agree, but if you guys are waiting on dependabot to make the updates automatically anyways. I can try and test to see if it will work down the line.

[poliorcetics]

I opened a PR for it dependabot/dependabot-core#5794, it should work but it's not merged yet.

It's probably possible to regenerate the docker container and use it locally to make the necessary changes but I have no idea how to do that. I'll gladly accept people testing it and telling me if it works has expected in a variety of configs though 👍