trivial: fix next_page/nextPage confusion in paginated MSW util
#2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 12, 2025
oxidecomputer/console@ab76183...e8b79c3 * [e8b79c3a](oxidecomputer/console@e8b79c3a) oxidecomputer/console#2987 * [ae965cff](oxidecomputer/console@ae965cff) oxidecomputer/console#2986 * [87656470](oxidecomputer/console@87656470) oxidecomputer/console#2981 * [886a26ab](oxidecomputer/console@886a26ab) oxidecomputer/console#2978 * [7f9dda20](oxidecomputer/console@7f9dda20) oxidecomputer/console#2975 * [063d0439](oxidecomputer/console@063d0439) oxidecomputer/console#2973 * [439c7dd3](oxidecomputer/console@439c7dd3) oxidecomputer/console#2971 * [601cdfa8](oxidecomputer/console@601cdfa8) oxidecomputer/console#2967 * [1f2019c8](oxidecomputer/console@1f2019c8) oxidecomputer/console#2966 * [170bf351](oxidecomputer/console@170bf351) oxidecomputer/console#2965 * [716fbbac](oxidecomputer/console@716fbbac) oxidecomputer/console#2962 * [e464bde6](oxidecomputer/console@e464bde6) oxidecomputer/console#2964
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 13, 2025
oxidecomputer/console@ab76183...e8b79c3 * [e8b79c3a](oxidecomputer/console@e8b79c3a) oxidecomputer/console#2987 * [ae965cff](oxidecomputer/console@ae965cff) oxidecomputer/console#2986 * [87656470](oxidecomputer/console@87656470) oxidecomputer/console#2981 * [886a26ab](oxidecomputer/console@886a26ab) oxidecomputer/console#2978 * [7f9dda20](oxidecomputer/console@7f9dda20) oxidecomputer/console#2975 * [063d0439](oxidecomputer/console@063d0439) oxidecomputer/console#2973 * [439c7dd3](oxidecomputer/console@439c7dd3) oxidecomputer/console#2971 * [601cdfa8](oxidecomputer/console@601cdfa8) oxidecomputer/console#2967 * [1f2019c8](oxidecomputer/console@1f2019c8) oxidecomputer/console#2966 * [170bf351](oxidecomputer/console@170bf351) oxidecomputer/console#2965 * [716fbbac](oxidecomputer/console@716fbbac) oxidecomputer/console#2962 * [e464bde6](oxidecomputer/console@e464bde6) oxidecomputer/console#2964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just clearing out an old to-do list item. We were incorrectly using
nextPageinstead ofnext_pagein the pagination helper. TypeScript allowed this becausenext_pageis optional and TypeScript can't prevent you from adding extra keys (nextPage) that aren't in the specified return type. This didn't cause any problems because on the client side, thenext_pageis converted tonextPageanyway. So we were just putting the "right" key in there to begin with and it was being left alone by the camel-casing logic. I explored finding ways to enforce an exact type which would disallow unexpected keys in API responses, but TypeScript makes this really tough (see microsoft/TypeScript#12936).