Skip to content

minor: remove throwOnError from qErrorsAllowed #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Nov 13, 2025
Merged

minor: remove throwOnError from qErrorsAllowed #2973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/api/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,10 @@ export const qErrorsAllowed = <Params, Data>(
// not want to share the cache and mix them up
queryKey: [f.name, params, ERRORS_ALLOWED],
queryFn: () => f(params).then(handleResult(f.name)),
// In the case of 404s, let the error bubble up to the error boundary so
// we can say Not Found. If you need to allow a 404 and want it to show
// up as `error` state instead, pass `throwOnError: false` as an
// option from the calling component and it will override this
throwOnError: (err) => err.statusCode === 404,
// No point having throwOnError because errors do not throw. Worth
// considering still throwing for particular errors: sometimes we expect
// a 403, other times we expect 404s. We could take a list of acceptable
// status codes.
...options,
})

Expand Down
Loading