Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prefetch IP pools for floating IP create #1969

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

david-crespo
Copy link
Collaborator

Didn't occur to me after we put the pool picker under the accordion, but we don't need to prefetch the list of IP pools since the list is hidden. Getting rid of the loader makes the create side modal pop up instantly.

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Feb 23, 2024 3:31am

@david-crespo david-crespo merged commit 264e2cd into main Feb 23, 2024
8 checks passed
@david-crespo david-crespo deleted the ip-pool-prefetch branch February 23, 2024 19:23
charliepark added a commit to oxidecomputer/omicron that referenced this pull request Feb 27, 2024
oxidecomputer/console@80f1167...e991ec5

* [e991ec5c](oxidecomputer/console@e991ec5c) oxidecomputer/console#1982
* [8e247f28](oxidecomputer/console@8e247f28) get rid of @oxide/gen alias
* [7d936d7e](oxidecomputer/console@7d936d7e) oxidecomputer/console#1981
* [b9a6051d](oxidecomputer/console@b9a6051d) delete unused app/table/headers
* [0b330247](oxidecomputer/console@0b330247) remove barrel files in app/pages
* [e53942ce](oxidecomputer/console@e53942ce) remove dot-path-fix vite plugin while we’re not using it
* [1af82bff](oxidecomputer/console@1af82bff) use vite-tsconfig-paths insead of my old manual thing
* [0f2411e8](oxidecomputer/console@0f2411e8) oxidecomputer/console#1962
* [bd64c620](oxidecomputer/console@bd64c620) oxidecomputer/console#1978
* [4388a92a](oxidecomputer/console@4388a92a) change pt-2 back to py-2 on AccordionItem
* [a0921bd6](oxidecomputer/console@a0921bd6) move msw handlers out of mock-api barrel file
* [6ab60b9b](oxidecomputer/console@6ab60b9b) update references to libs/ everywhere
* [9b4a6e0f](oxidecomputer/console@9b4a6e0f) move classed out of util barrel
* [d731de2b](oxidecomputer/console@d731de2b) oxidecomputer/console#1977
* [6c5883d9](oxidecomputer/console@6c5883d9) oxidecomputer/console#1976
* [6de56b15](oxidecomputer/console@6de56b15) oxidecomputer/console#1975
* [bbf019ee](oxidecomputer/console@bbf019ee) oxidecomputer/console#1973
* [b9c1892d](oxidecomputer/console@b9c1892d) oxidecomputer/console#1974
* [e2e56d87](oxidecomputer/console@e2e56d87) Revert `try .git-blame-ignore-revs`. don’t like it
* [1745a752](oxidecomputer/console@1745a752) try .git-blame-ignore-revs
* [4bfd2275](oxidecomputer/console@4bfd2275) oxidecomputer/console#1971
* [cb109cba](oxidecomputer/console@cb109cba) oxidecomputer/console#1968
* [264e2cd1](oxidecomputer/console@264e2cd1) oxidecomputer/console#1969
* [3ec255f9](oxidecomputer/console@3ec255f9) Revert `Shuffle @oxide/pagination files  (oxidecomputer/console#1970)`
* [3eebf491](oxidecomputer/console@3eebf491) oxidecomputer/console#1970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant