Reworked deadlock handling, fixed a few other issues #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpretty-cyro
commented
Sep 2, 2024
mpretty-cyro
commented
- Fixed an issue where the background task to finish sending messages may not have sent the sync message or the main message after and upload
- Fixed an issue where the SessionBackgroundTask was incorrectly reporting a failure to be created
- Fixed an incorrect modal action colour
- Fixed a crash when creating legacy groups
- Updated the code so that we take charge of resolving the deadlock issue instead of relying on GRDB to do it
- Updated the logic to timeout the SessionBackgroundTask with 5 seconds of background time remaining (to ensure we have enough time to suspend the network & database)
• Fixed an issue where the background task to finish sending messages may not have sent the sync message or the main message after and upload • Fixed an issue where the SessionBackgroundTask was incorrectly reporting a failure to be created • Fixed an incorrect modal action colour • Fixed a crash when creating legacy groups • Updated the code so that we take charge of resolving the deadlock issue instead of relying on GRDB to do it • Updated the logic to timeout the SessionBackgroundTask with 5 seconds of background time remaining (to ensure we have enough time to suspend the network & database)
RyanRory
approved these changes
Sep 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.