Fix/conversation deletion issues #1695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making sure we deleted conversations when a contact is missing from the config while existing locally
simophin
reviewed
Oct 17, 2024
| } == null | ||
| } | ||
| removedContacts.forEach { | ||
| getThreadId(fromSerialized(it.accountID))?.let(::deleteConversation) |
There was a problem hiding this comment.
I'm wondering if we should also remove other data. Like the one in ProfileManager. If you look at the code in the same function, back in around line 1233, new contacts get added into ProfileManager also.
There was a problem hiding this comment.
I think the process of a thread deletion takes that into account eventually in threadDeleted.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-2464 - Making sure that a deleted conversation heads back to the home page on a clear stack
SES-2522 - Making sure we hide contacts that are missing from the config file