Feature/standardised message deletion #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleaned up older references to align with newer look
Cleaning unused code
…from the db directly
Split the `BASE_DELETED_TYPE` into two types: BASE_DELETED_OUTGOING_TYPE and BASE_DELETED_INCOMING_TYPE so we can differentiate them visually.
Still need to finalise "note to self" and "legacy groups"
Moving away from promises
Hndling unsend request retrieval as per figma docs
Sharing admin logic
Also rethemed the send buttona dn home plus button to have better ax contrast by standardising the colour displayed on the accent color to be the same as the one on the sent messages
We removed the 'delete locally' dialog, instead we show the 'delete for everyone' with the second option disabled
Cleaned up invisible copy button on black bgs
AL-Session
reviewed
Oct 9, 2024
app/src/main/java/org/thoughtcrime/securesms/attachments/DatabaseAttachmentProvider.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationViewModel.kt
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationViewModel.kt
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/repository/ConversationRepository.kt
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/repository/ConversationRepository.kt
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| override suspend fun delete1on1MessagesRemotely( |
There was a problem hiding this comment.
I don't see anything that requires suspend in the function body?
There was a problem hiding this comment.
I made it a suspend as a safety mechanism to force the calling point to use this from a coroutine.
I guess another option would be to use a context directly in the method here to keep the responsibility local.
Only force the priority to visible when going from not approved to approved
SessionHero01
approved these changes
Oct 10, 2024
Syncing happens in the bg so the user doesn't need to know of it hence the status can display as "Sent" during the syncing phase. Resyncing, in case it happens, can display the "Syncing" status as it would happen after a syncing error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: [SES 1792]
Description:
Standardising message deletion across platforms.
See the Figma link in the Jira ticket for implementation details and updated UI and logic rules.