New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes when removing spaces in mention texts #1680

Merged

ThomasSession merged 1 commit into release/1.20.0 from fix-mention-crash

Sep 24, 2024

Collaborator

SessionHero01 commented Sep 24, 2024 •

edited

Loading

Safe guard a few places so exception cases be handled:

When deleting the space after a mention, the span will occupy the trailing of the text, which will have a special case of end offset == string length. Addition to it is definitely not going to go well.
When deleting the space after a mention, then start another mention, it will create a mention span overlap, which will also crash the app. The normalisation will also need to take this into consideration.


          Fix crashes when removing spaces in mention texts

7e1a0ad

SessionHero01 requested a review from ThomasSession

September 24, 2024 02:03

ThomasSession approved these changes

View reviewed changes

ThomasSession merged commit 439ec90 into release/1.20.0

2 checks passed

ThomasSession deleted the fix-mention-crash branch

September 24, 2024 03:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet