Feature/debug menu #1645
Merged
Feature/debug menu #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing compose copy that wasn't set up properly...
Added a debug menu It can be accessed from the settings page or via an app shortcut (from the app icon)
We can now switch environments between mainnet and testnet
AL-Session
approved these changes
Aug 26, 2024
| @@ -498,27 +509,33 @@ class SettingsActivity : PassphraseRequiredActionBarActivity() { | |||
|
|
|||
| Cell { | |||
| Column { | |||
| // add the debug menu in non release builds | |||
| if (BuildConfig.BUILD_TYPE != "release") { | |||
There was a problem hiding this comment.
Prevent string comparison and any potential typos?
Suggested change
| if (BuildConfig.BUILD_TYPE != "release") { | |
| if (BuildConfig.BUILD_TYPE == BuildConfig.DEBUG) { |
There was a problem hiding this comment.
@AL-Session I considered this but I want to add a QA build type in the future. That build type should have the debug menu available, so unfortunately it needs to be compared to release.
app/src/main/java/org/thoughtcrime/securesms/debugmenu/DebugMenu.kt
Outdated
Show resolved
Hide resolved
simophin
approved these changes
Aug 26, 2024
…nu.kt Co-authored-by: AL-Session <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a debug menu.
For now it simply allows us to switch between mainnet and testnet.
The debug menu can be accessed in two ways:
Debug MenuThe debug menu should not be accessible in release builds.