[SES-2512] Rewrite ProfilePictureView #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // to launch a coroutine from a view. The potential memory leak is not a concern here, as | ||
| // the coroutine is very short-lived. If you change the code here to be long live then you'll | ||
| // need to find a better scope to launch the coroutine from. | ||
| lastLoadJob = GlobalScope.launch(Dispatchers.Main) { |
There was a problem hiding this comment.
This is definitely not ideal... The whole view is problematic, which is unfortunately not a new problem. We really shouldn't be having so much heavy logic in a piece of UI...
There's isn't too much else we can do with the current set up...
This will be part of the things we can fix once we move away from the xml views.
added 4 commits
August 19, 2024 13:48
# Conflicts: # app/src/main/res/values/ids.xml
simophin
pushed a commit
that referenced
this pull request
Aug 20, 2024
This reverts commit 9919f71.
simophin
added a commit
that referenced
this pull request
Aug 20, 2024
This reverts commit 9919f71. Co-authored-by: fanchao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the
ProfilePictureViewso that it defers the db access to non-UI threads.