Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SES-2524 - Rewrite media gallery in Compose #1619

Merged
merged 28 commits into from
Aug 19, 2024
Merged

SES-2524 - Rewrite media gallery in Compose #1619

merged 28 commits into from
Aug 19, 2024

Conversation

simophin
Copy link

@simophin simophin commented Aug 14, 2024 •
edited
Loading

A few additions along side the rewrite:

  1. Added java8's date time library through Android desugaring process. This is to rewrite the time grouping for photos.
  2. Have to update AGP to 8.5 for the new desugaring
Screen_recording_20240814_114635.webm

@simophin simophin marked this pull request as ready for review August 14, 2024 01:15
fanchao and others added 15 commits August 14, 2024 11:17
Remove sticky header aar
e8d161e
Only request permission on <= 28
4947663
Close nav
83bf252
Merge remote-tracking branch 'origin/dev' into rewrite-media-gallery-…
2b19dd1 
…compose

# Conflicts:
#	app/src/main/java/org/thoughtcrime/securesms/MediaOverviewActivity.java
#	app/src/main/java/org/thoughtcrime/securesms/preferences/PrivacySettingsPreferenceFragment.kt
Remove desugaring
d148960
Fix compilation issue
893835c
@ThomasSession
Removed uneeded state and aded haptic feedback onlongpress
dbbd899
@ThomasSession
Proper styling for the headers
105c3f0
@ThomasSession
UI tweaks
6ff4b40 
Red delete button
AlertDialog fixes
Using LocalDimensions
@ThomasSession
New AppBar structure
3e43c9d 
More flexible app bar options
Also fixed some styling issues
Move selection mode back into view model
b81e2eb
Back button content description
be2c74c
Use "No documents" string instead
7f66b34
Add attachment URI as part of the conversation watching URIs
a3eb2c5
Notify conversation updated after deletion completes
c5e2bea
AL-Session
AL-Session approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@AL-Session AL-Session left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - your Compose Kung-Fu is strong! =D

Couple of comments, but I trust you to deal with as you see fit.

build.gradle Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
#Thu Dec 30 07:09:53 SAST 2021
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! =D

@simophin simophin merged commit 16d6efb into dev Aug 19, 2024
0 of 2 checks passed
@simophin simophin deleted the rewrite-media-gallery-compose branch August 19, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AL-Session AL-Session AL-Session approved these changes

@ThomasSession ThomasSession ThomasSession approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simophin @AL-Session @ThomasSession