Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedule the fetch 4 hours after last check if it was within 4 hours, instead of just 4 hours from now.
Renamed
versionUtil
toVersionDataFetcher
Util
VersionData
3. Fixed the timing issue where if we checked 1 second before the last check had expired, we would wait another 4 hours, meaning we would call up to 8 hours since the last call.Removed
job?.cancel()
as the Job was not cancellable, so achieved nothing, but looked like it was doing something, which was potentially misleading.call
stopTimedVersionCheck()
at the start ofstartTimedVersionCheck()
to prevent any duplicates being posted.Utilise
delayTimeMillis < 0 { post immediately }
inHandler.postDelayed
for simplified code.fetchVersionData
as it's always scheduled at the correct time.@Inject
it.