[QA-31] Fix dialog not shown on seed send attempt #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bemusementpark
changed the title
ThomasSession
approved these changes
Jul 29, 2024
AL-Session
approved these changes
Jul 29, 2024
| showSessionDialog { | ||
| title(R.string.dialog_send_seed_title) | ||
| text(R.string.dialog_send_seed_explanation) | ||
| button(R.string.dialog_send_seed_send_button_title) { sendTextOnlyMessage(true) } |
There was a problem hiding this comment.
Would it be better to have a mutable copy of the argument which we can flip to true rather than calling ourselves, and then we just return null on cancel?
There was a problem hiding this comment.
Sorry, this one was mostly a revert so I merged w/one
IDK if I understand, but it could make sense for showDialog or some variant to be a suspending function like Snackbar is... 🤔 so you call val result = showDialog(...)
but right now it's not true recursion, as sendTextOnlyMessage(true) is called in a listener as a response to a click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.