Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-40 - MMS Notification Strings #1541

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

AL-Session
Copy link
Collaborator

@AL-Session AL-Session commented Jul 10, 2024

Contributor checklist

  • I have tested my contribution on these devices:
  • Virtual Pixel 3a, Android 9 API 28
  • Virtual Pixel 3a, Android 14 API 34
  • My contribution is fully baked and ready to be merged as is
    - [X] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This PR performs the following work:

  • Removes three strings (which were never shown to the user in the first place),
  • Introduces the Phrase library, and
  • Uses the phrase library for substitution of emojis into the attachmentsNotification string ("{emoji} Attachment").

To test this code just send some messages with various file types (images, GIFs, audio, voice messages, etc.) between devices. If the receiving device does not have Session currently active the notification will be displayed containing a relevant emoji, (e.g., "📷 Attachment", etc.).

Additionally, if the receiving device has the Session open but at the home screen then the snippet for that conversation will be updated to use the "📷 Attachment" text (as appropriate for the attachment type).

While this ticket is really part of the Strings chunk of work, I've based this PR on dev because Strings will be worked on for a while longer and needs to have both the Groups and Onboarding chunks merged before it can be finalised (with new strings hooked into the new functionality) before Strings itself can be merged into dev. As such, if I'd based this on Strings it would have grown stale waiting for that to happen as we can't PR this code back into the non-PR'd Strings code!

@AL-Session AL-Session marked this pull request as ready for review July 10, 2024 05:10
@AL-Session AL-Session marked this pull request as draft July 10, 2024 05:40
@AL-Session AL-Session marked this pull request as ready for review July 14, 2024 23:28
@AL-Session AL-Session merged commit 1ca6262 into oxen-io:dev Jul 16, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants