forked from signalapp/Signal-Android
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS-40 - MMS Notification Strings #1541
Merged
AL-Session
merged 8 commits into
oxen-io:dev
from
AL-Session:SS40_MmsNotificationStrings
Jul 16, 2024
Merged
SS-40 - MMS Notification Strings #1541
AL-Session
merged 8 commits into
oxen-io:dev
from
AL-Session:SS40_MmsNotificationStrings
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/org/thoughtcrime/securesms/database/model/NotificationMmsMessageRecord.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/notifications/DefaultMessageNotifier.java
Outdated
Show resolved
Hide resolved
ThomasSession
approved these changes
Jul 15, 2024
bemusementpark
approved these changes
Jul 15, 2024
app/src/main/java/org/thoughtcrime/securesms/database/model/NotificationMmsMessageRecord.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/notifications/DefaultMessageNotifier.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/notifications/DefaultMessageNotifier.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
- [X] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using theFixes #1234
syntaxDescription
This PR performs the following work:
attachmentsNotification
string ("{emoji} Attachment
").To test this code just send some messages with various file types (images, GIFs, audio, voice messages, etc.) between devices. If the receiving device does not have Session currently active the notification will be displayed containing a relevant emoji, (e.g., "📷 Attachment", etc.).
Additionally, if the receiving device has the Session open but at the home screen then the snippet for that conversation will be updated to use the "📷 Attachment" text (as appropriate for the attachment type).
While this ticket is really part of the Strings chunk of work, I've based this PR on
dev
because Strings will be worked on for a while longer and needs to have both the Groups and Onboarding chunks merged before it can be finalised (with new strings hooked into the new functionality) before Strings itself can be merged intodev
. As such, if I'd based this on Strings it would have grown stale waiting for that to happen as we can't PR this code back into the non-PR'd Strings code!