Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-2168 - User profile warnings #1531

Merged
merged 14 commits into from
Jul 9, 2024

Conversation

AL-Session
Copy link
Collaborator

@AL-Session AL-Session commented Jul 7, 2024

Contributor checklist

  • I have tested my contribution on these devices:
  • Virtual Pixel 3a, Android 9 API 28
  • My contribution is fully baked and ready to be merged as is
    - [ ] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This PR is to add user feedback in the following situations:

  • Profile picture upload failed (Toast: "Failed to update profile"), and
  • Profile picture removal failed (Toast: "Failed to remove display picture")

The OkHttp, conscrypt, and androidx core libraries were updated in the process of experimentation to add this functionality. Although the final result can be achieved without these updates, I see little reason to roll them back to our old, stale library versions when these fresh versions work just fine.

To test this PR you might like to:

  • Put the device in Airplane mode and attempt to upload a profile picture - when it fails you'll see the toast "Failed to update profile", and
  • With an existing profile picture, put the device in Airplane mode and then attempt to remove the profile picture. When the network sync of the profile picture removal fails the error toast "Failed to remove profile picture" will display.

Note: while we could remove the local profile picture even if the network sync failed, this would be confusing and would also deny the user the chance to retry removal. Also, it could look to them as if they had no profile picture, but online to others they could - so it's best not to break that sync imho.

@AL-Session AL-Session requested a review from simophin July 8, 2024 05:37
@AL-Session AL-Session force-pushed the SS-2168_UserProfileWarnings branch from b210678 to 34ce119 Compare July 9, 2024 04:45
@AL-Session
Copy link
Collaborator Author

Reverted previous dev merge and force-pushed updated dev merge.

@AL-Session AL-Session merged commit 2e3acd9 into oxen-io:dev Jul 9, 2024
1 check passed
@AL-Session AL-Session deleted the SS-2168_UserProfileWarnings branch July 22, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants