Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SS-54] Add dialog to allow local deletion if network deletion fails #1526

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

AL-Session
Copy link
Collaborator

@AL-Session AL-Session commented Jun 27, 2024

Contributor checklist

  • I have tested my contribution on these devices:
  • Virtual Pixel 3a, Android 9 API 28
  • Virtual Pixel 3a, Android 14 API 34
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

New functionality: If the user goes to Settings > Clear Data and chooses to "Clear device and network", then should the network data deletion fail the user is informed of this issue and asked if they would like to delete local device data only instead. If they proceed then local device data is deleted as if that had been their first choice.

One way to quickly test this functionality & see this new modal dialog is to:

  • Get to the point where you can "Clear device and network", and then
  • Drag down from the top of the screen to show the Android settings and turn Flight Mode on, then
  • Click the current modal's "Clear" button.

As we're in flight mode, a short while after we attempt to perform the network deletion it will fail and the new modal displaying "An unknown error occurred and your data was not deleted. Do you want to delete your data from just this device instead? [Clear Device] [Cancel]". At this point the [Clear Device] button will do just that, while the [Cancel] button will cancel out of the operation.

@AL-Session AL-Session changed the title [SS-54] Add network clear error dialog [SS-54] Add dialog to allow local deletion only if network deletion fails Jun 27, 2024
@AL-Session AL-Session changed the title [SS-54] Add dialog to allow local deletion only if network deletion fails [SS-54] Add dialog to allow local deletion if network deletion fails Jun 27, 2024
@AL-Session AL-Session force-pushed the SS-54_AddNetworkClearErrorDialog branch from e71d8c1 to b387ee3 Compare June 27, 2024 06:41
@AL-Session
Copy link
Collaborator Author

Reversion of dev merge & libsession-util addition has been undone following dev process meeting.

Copy link

@bemusementpark bemusementpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@AL-Session AL-Session merged commit a30f001 into oxen-io:dev Jul 2, 2024
1 check passed
@AL-Session AL-Session deleted the SS-54_AddNetworkClearErrorDialog branch July 22, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants