forked from signalapp/Signal-Android
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SS-54] Add dialog to allow local deletion if network deletion fails #1526
Merged
AL-Session
merged 10 commits into
oxen-io:dev
from
AL-Session:SS-54_AddNetworkClearErrorDialog
Jul 2, 2024
Merged
[SS-54] Add dialog to allow local deletion if network deletion fails #1526
AL-Session
merged 10 commits into
oxen-io:dev
from
AL-Session:SS-54_AddNetworkClearErrorDialog
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AL-Session
changed the title
[SS-54] Add network clear error dialog
[SS-54] Add dialog to allow local deletion only if network deletion fails
Jun 27, 2024
AL-Session
changed the title
[SS-54] Add dialog to allow local deletion only if network deletion fails
[SS-54] Add dialog to allow local deletion if network deletion fails
Jun 27, 2024
AL-Session
force-pushed
the
SS-54_AddNetworkClearErrorDialog
branch
from
June 27, 2024 06:41
e71d8c1
to
b387ee3
Compare
Reversion of |
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
bemusementpark
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/preferences/ClearAllDataDialog.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234
syntaxDescription
New functionality: If the user goes to Settings > Clear Data and chooses to "Clear device and network", then should the network data deletion fail the user is informed of this issue and asked if they would like to delete local device data only instead. If they proceed then local device data is deleted as if that had been their first choice.
One way to quickly test this functionality & see this new modal dialog is to:
As we're in flight mode, a short while after we attempt to perform the network deletion it will fail and the new modal displaying "An unknown error occurred and your data was not deleted. Do you want to delete your data from just this device instead? [Clear Device] [Cancel]". At this point the [Clear Device] button will do just that, while the [Cancel] button will cancel out of the operation.