[SES-1935] Audio recording crash #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simophin
force-pushed
the
ses-1935-audio-recording-crash
branch
from
5904853
to
1354bcc
Compare
simophin
force-pushed
the
ses-1935-audio-recording-crash
branch
from
1354bcc
to
27fcc66
Compare
bemusementpark
approved these changes
May 21, 2024
There was a problem hiding this comment.
Looks good, though now, without a stacktrace, the text makes even less sense than before.
So it's probably worth removing the log, or at least saying what went wrong, as the text We can only record once at a time. is more of an explanation, but we don't say audioCode was expected to be null or audioCodec = x and playing = true...
I'm happy either way, remove log, or make it a little more informative.
bemusementpark
approved these changes
May 22, 2024
|
Hey @bemusementpark or @AL-Session can I ask either of you to merge this one pls? It has passed QA |
|
It'd be nice, but IDK if we're merging to dev, or some release branch, so don't worry about it for now. |
AL-Session
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to find a way to trigger a double call to
startRecordingand failed to find any. Instead of hard crashing the app, I think it's ok to ignore the edge case here, by logging the invariant then return early.So the worst thing it could happen is for some edgy case the recording can't be started.