[SES-637] - Stop playing message if deleted #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simophin
requested review from
AL-Session and
bemusementpark
and removed request for
AL-Session
bemusementpark
approved these changes
May 17, 2024
| @@ -103,6 +103,7 @@ import org.thoughtcrime.securesms.ApplicationContext | |||
| import org.thoughtcrime.securesms.PassphraseRequiredActionBarActivity | |||
| import org.thoughtcrime.securesms.attachments.ScreenshotObserver | |||
| import org.thoughtcrime.securesms.audio.AudioRecorder | |||
| import org.thoughtcrime.securesms.audio.AudioSlidePlayer | |||
There was a problem hiding this comment.
Yep. We should def put in some automation for the code standard :-)
| override fun onCleared() { | ||
| super.onCleared() | ||
|
|
||
| // Stop all voice message when existing the convo page |
| message is MmsMessageRecord && | ||
| message.slideDeck.audioSlide == audioSlide) { | ||
| player.stop() | ||
| } |
There was a problem hiding this comment.
May as well defer getInstance to when it is necessary as it's synchronized.
val mmsMessage = message as? MmsMessageRecord ?: return
val audioSlide = mmsMessage.slideDeck.audioSlide ?: return
AudioSlidePlayer.getInstance()?.takeIf { it.audioSlide == audioSlide }?.stop()
bemusementpark
approved these changes
May 20, 2024
AL-Session
approved these changes
May 20, 2024
bemusementpark
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription