[SES-1889] Fix IndexOutOfBounds in MediaPreview #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AL-Session
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is a crash that occurs onResume we load the cursor again and then set the pager position and that triggers viewPagerListener, but the listener is reused and holds an index which may or may not be valid. As range checks only check index is positive, we might have an index that exceeds the bounds, and if
leftIsRecentis set then its reversed. This commit fixes the issue and adds some additional info if we do throw.It'd be good to rewrite this class in the near future
Th clamping in
onLoadFinishedalso improves an issue when the Activity is started wiyh an inalid index causing the pager to not be populated at all when the activity is opened