Fix share logs dialog blocks to prevent weird context switching blocking the share dialog #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king the share dialog
| cancelButton { dismiss() } | ||
| } | ||
|
|
||
| private fun shareLogs() { | ||
| shareJob?.cancel() | ||
| shareJob = lifecycleScope.launch(Dispatchers.IO) { |
There was a problem hiding this comment.
Was it still useful to schedule the work?
could move it down, so it is just around the actual IO, and grab a reference to ApplicationContext around here first.
There was a problem hiding this comment.
I tried to turn this into a suspending function and run the shareLogs() call in a runBlocking { } block, but then it was getting a LifecycleScope cancellation in the job itself, while also having some weird issues around context switching trying to launch the chooser intent. I'm not sure if it was easier to just run it this way since the only way I could get the job to run properly was to basically block the main thread the equivalent way 🤷
…ismiss when button listeners are triggered, change the share logs dialog to operate on main thread and switch context when generating files instead
bemusementpark
approved these changes
Jul 28, 2023
…we open the picker intent
|
Fixed with minimal code changes in #1295 as discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Samsung device that was preventing share dialog properly showing the chooser intent.
calls to requireContext() or referenced the context of the dialog were being used after the dismissal of the dialog, leading to a detached context error