Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SES-205] Fix message clipping #1277

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

bemusementpark
Copy link

@bemusementpark bemusementpark commented Jul 19, 2023

using layout_weight on messageContentView doesn't work well when it is drawn to bitmap as the bitmap will contain a lot of empty space causing it to be cut off. It also pushes the timestamp to the edge.

Screen Shot 2023-07-18 at 1 40 04 pm

This PR fixes the issue by

  1. removing weight from messageContentView and setting its width to wrap_content
  2. wrapping messageInnerLayout with a FrameLayout as the margin_end on profile pic was not respected unless profile && messageInnerContainer were chained. But when it was chained bias on messageInnerLayout was not respected, so views would not appear in the correct places. So this FrameLayout allows us to place child layout at the start or end and allows us to hold the margin here.

@bemusementpark bemusementpark changed the title Fix message clipping [SES-205] Fix message clipping Jul 20, 2023
@bemusementpark bemusementpark merged commit 9af6dc9 into oxen-io:dev Jul 20, 2023
@bemusementpark bemusementpark deleted the fix-clip branch July 20, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants