Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
layout_weight
onmessageContentView
doesn't work well when it is drawn to bitmap as the bitmap will contain a lot of empty space causing it to be cut off. It also pushes the timestamp to the edge.This PR fixes the issue by
weight
frommessageContentView
and setting its width towrap_content
FrameLayout
as themargin_end
onprofile pic
was not respected unlessprofile && messageInnerContainer
were chained. But when it was chained bias onmessageInnerLayout
was not respected, so views would not appear in the correct places. So this FrameLayout allows us to place child layout at the start or end and allows us to hold the margin here.