Utilise new Push Notification endpoint for 1-on-1 conversations. #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency for only the play version of the app. Add support for requests in new pn server
…f assuming utf-8 encoding for strings
Finishes the WIP for subscribing to push notifications and handling the new-style pushes we get.
hjubb
reviewed
Jul 5, 2023
| import android.content.Context | ||
| import org.session.libsession.utilities.TextSecurePreferences | ||
|
|
||
| class FcmTokenManager( |
There was a problem hiding this comment.
We might want to rename this PushTokenManager or something in case we want to support multiple generic push token implementations, even though all the preferences stuff are using FCM wording 🤔
| fun unregister( | ||
| token: String, | ||
| userPublicKey: String, | ||
| userEdKey: KeyPair |
There was a problem hiding this comment.
I'm not sure if the API needs namespaces in the unsubscribe signature data, but if we pass even an empty list as default here we will probably avoid issues in the future if we ever call register with specific namespaces above
|
|
||
| enum class Server(val url: String, val publicKey: String) { | ||
| LATEST("https://push.getsession.org", "d7557fe563e2610de876c0ac7341b62f3c82d5eea4b62c702392ea4368f51b3b"), | ||
| LEGACY("https://dev.apns.getsession.org", "642a6585919742e5a2d4dc51244964fbcd8bcab2b75612407de58b810740d049") |
There was a problem hiding this comment.
Should this one still be dev or we are just testing it for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.