Fixed a few issues with the OpenGroupPoller #1241
Conversation
mpretty-cyro
commented
Jun 7, 2023
mpretty-cyro
commented
- Fixed an issue where the admin/moderator status wasn't getting stored if set before joining a community
- Fixed an issue where multiple pollers for the same server could run at the same time when joining multiple rooms within the same app run (very noticeable when restoring/linking)
Fixed an issue where the admin/moderator status wasn't getting stored if set before joining a community Fixed an issue where multiple pollers for the same server could run at the same time when joining multiple rooms within the same app run (very noticeable when restoring/linking)
app/src/main/java/org/thoughtcrime/securesms/groups/OpenGroupManager.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/org/session/libsession/messaging/sending_receiving/pollers/OpenGroupPoller.kt
Outdated
Show resolved
Hide resolved
| @@ -41,11 +41,13 @@ object OpenGroupManager { | |||
| isPolling = true | |||
| val storage = MessagingModuleConfiguration.shared.storage | |||
| val servers = storage.getAllOpenGroups().values.map { it.server }.toSet() | |||
There was a problem hiding this comment.
So the conversion to Set<T> is in order to remove duplicates from the collection - getAllOpenGroups() returns every community you are a member of, so if you are in multiple rooms on the same server (eg. Session, Oxen, Session Updates all on the getsession.org server) the result would have 3 entries for getsession.org
The poll request actually makes a single /batch API call to the server which includes a call for each room on that server (so without the toSet() the forEach loop would end up redundantly initialising and triggering a poll for each copy of the server)
.../src/main/java/org/session/libsession/messaging/sending_receiving/pollers/OpenGroupPoller.kt
Outdated
Show resolved
Hide resolved
| }.fail { | ||
| updateCapabilitiesIfNeeded(isPostCapabilitiesRetry, it) | ||
| updateCapabilitiesIfNeeded(isPostCapabilitiesRetry, currentRunId, it) | ||
| }.map { } |
There was a problem hiding this comment.
The map was there to convert the return value from Promise<List<OpenGroupApi.BatchResponse<*>>, Exception> to Promise<Unit, Exception>
libsession/src/main/java/org/session/libsession/messaging/open_groups/OpenGroupApi.kt
Outdated
Show resolved
Hide resolved
