Add button downstates to appearance settings screen #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjubb
reviewed
Jun 15, 2023
| @@ -125,29 +125,6 @@ private boolean isBottom(int position) { | |||
| return next instanceof PreferenceCategory; | |||
| } | |||
|
|
|||
| public Drawable getBackground(Context context, int position) { | |||
There was a problem hiding this comment.
I'm guessing this doesn't break things for the other settings screens (chats, notifications etc all the other ones?)
There was a problem hiding this comment.
Your concern is well founded as this breaks all of the preference backgrounds.
There was a problem hiding this comment.
reverted... well mostly, I added ripple to those buttons 🎉
bemusementpark
changed the title
hjubb
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds downstate to most buttons in settings, and utilises the rounding from
CardViewfor the rounded corners on the top and bottom buttons.device-2023-05-29-183310.webm