feat: increase voice recording limit to 5m #1201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
i just took a sample on android and i got 257KiB from a 55s long recording.
this would mean we could actually record 431s (
1.97 * 1024/(257/55 * 60) * 60
) before the file exceeds 1.97MiB. this assumes a constant bitrate and i'm not sure that's realistic. it seems realistic to assume that upping the duration limit to 5 minutes on session-android would not exceed the 1.97MiB that seem applied on session-desktop.fixes #1182.