Skip to content

Modify examples for empty brace spaces rule#801

Closed
isnifer wants to merge 1 commit intooxc-project:mainfrom
isnifer:patch-1
Closed

Modify examples for empty brace spaces rule#801
isnifer wants to merge 1 commit intooxc-project:mainfrom
isnifer:patch-1

Conversation

@isnifer
Copy link

@isnifer isnifer commented Jan 18, 2026

Updated examples to include spaces in empty braces.

Updated examples to include spaces in empty braces.

Signed-off-by: Anton Kuznetsov <1788245+isnifer@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for oxc-project ready!

Name Link
🔨 Latest commit 9f5b813
🔍 Latest deploy log https://app.netlify.com/projects/oxc-project/deploys/696d54c698f5cf00086e0024
😎 Deploy Preview https://deploy-preview-801--oxc-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@connorshea
Copy link
Member

connorshea commented Jan 19, 2026

This one is unfortunately due to us using oxfmt to reformat the docs, I think we probably need to add a "disable" comment here somehow to prevent oxfmt from reformatting this section of the page, but I'm not totally sure.

You can see that it's correct in the original rust doc comment: https://github.com/oxc-project/oxc/blob/22298236813777743a3d7ce3f29e819e596dcd26/crates/oxc_linter/src/rules/unicorn/empty_brace_spaces.rs

@isnifer
Copy link
Author

isnifer commented Jan 19, 2026

@connorshea yeah, I thought the same way. Hope you'll find an opportunity to make it right.

@connorshea
Copy link
Member

It looks like adding the ignore comments worked when I tested it locally, so this'll be fixed by oxc-project/oxc#18203, and all these changes will show up after we regenerate the docs tomorrow 👍 Thanks!

@connorshea connorshea closed this Jan 19, 2026
graphite-app bot pushed a commit to oxc-project/oxc that referenced this pull request Jan 19, 2026
…8203)

Add ignore comments to prevent oxfmt/prettier reformatting the example code here.

Pointed out by oxc-project/website#801
@connorshea
Copy link
Member

connorshea commented Jan 19, 2026

all three of these are now fixed on the live site, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants