Conversation
✅ Deploy Preview for oxc-project ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb8686df64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/docs/guide/usage/linter/rules/vitest/require-mock-type-parameters.md
Show resolved
Hide resolved
| #### fix.variables | ||
|
|
||
| type: `"off" | "suggestion" | "fix"` | ||
| type: `"off" | "suggestion" | "fix" | "safe-fix"` |
There was a problem hiding this comment.
Remove unsupported
safe-fix from fix.variables type
This type declaration advertises "safe-fix" as a valid value for fix.variables, but the section below states that safe-fix is only applicable to imports and unavailable for variables. That contradiction makes the option schema misleading and can cause users to set fix.variables: "safe-fix" expecting behavior that the page itself says is unsupported.
Useful? React with 👍 / 👎.
From oxc-project/oxc#20867