Skip to content

test: add some basic e2e tests#63

Merged
Boshen merged 6 commits intomainfrom
tests
Aug 12, 2025
Merged

test: add some basic e2e tests#63
Boshen merged 6 commits intomainfrom
tests

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 7, 2025

./test.sh currently errors with

fatal error: all goroutines are asleep - deadlock!

It doesn't seem to work with other .ts file extensions found in real projects:

panic: ScriptKind must be specified when parsing source files.

goroutine 4442 [running]:
github.com/microsoft/typescript-go/internal/parser.(*Parser).initializeState(0x101bd3c20?, {{0x1400001a640, 0x41}, {0x14005e6d7c0, 0x41}, {0x0, 0x0, 0x0, 0x0}, {0x1, ...}, ...}, ...)

Question: should js extensions be allowed as well?

@auvred
Copy link
Collaborator

auvred commented Aug 7, 2025

It doesn't seem to work with other .ts file extensions found in real projects:

Fixed 16b391f

@auvred
Copy link
Collaborator

auvred commented Aug 7, 2025

Question: should js extensions be allowed as well?

https://typescript-eslint.io/blog/project-service#additional-files

It's often desirable to lint .js files using type-aware rules - especially *.config.js files and misc scripts written in JS.

@Boshen
Copy link
Member Author

Boshen commented Aug 7, 2025

Everything worked! I'll continue add more tests to this branch, until we have proper e2e test setup.

@Boshen
Copy link
Member Author

Boshen commented Aug 12, 2025

Merging to keep the ball rolling. Need to setup a proper e2e test suite in go at some point.

@Boshen Boshen changed the title some basic tests test: add some basic e2e tests Aug 12, 2025
@Boshen Boshen merged commit 7c06945 into main Aug 12, 2025
4 checks passed
@Boshen Boshen deleted the tests branch August 12, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants