Add a JSON Schema implementation for the regex crate#9
Merged
Boshen merged 2 commits intooxc-project:mainfrom Nov 23, 2025
Merged
Add a JSON Schema implementation for the regex crate#9Boshen merged 2 commits intooxc-project:mainfrom
Boshen merged 2 commits intooxc-project:mainfrom
Conversation
connorshea
pushed a commit
that referenced
this pull request
Nov 23, 2025
## 🤖 New release * `oxc-schemars`: 0.8.26 -> 0.8.27 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.8.27](oxc-schemars-v0.8.26...oxc-schemars-v0.8.27) - 2025-11-23 ### Fixed - Regenerate the test snapshots. ([#11](#11)) ### Other - Add a JSON Schema implementation for the regex crate ([#9](#9)) - Update examples/tests so they pass again. ([#8](#8)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Nov 23, 2025
…ts (#15978) ~~Draft until we merge oxc-project/schemars#9 and upgrade the oxc-schemars crate in this repo afterwards. Once we have the schemars crate bumped up to 0.8.27 we can safely rebase this branch and this'll be ready to merge.~~ But I can confirm that this now works with my patch to schemars :D Part of #14743. Generated docs: ```md ## Configuration This rule accepts a configuration object with the following properties: ### ignore type: `string[]` A list of patterns to ignore when checking `catch` variable names. The pattern can be a string or regular expression. ### name type: `string` default: `"error"` The name to use for error variables in `catch` blocks. You can customize it to something other than `'error'` (e.g., `'exception'`). ``` Unfortunately it doesn't recognize the default value in this case, although I'm not 100% sure why. But at the very least, this works and allows us to finish the docs for most of the remaining lint rules. ```md ## Configuration This rule accepts a configuration object with the following properties: ### rejectPattern type: `[ string, null ]` Regex pattern used to validate the `reject` parameter name. If provided, this pattern is used instead of the default `^_?reject$` check. ### resolvePattern type: `[ string, null ]` Regex pattern used to validate the `resolve` parameter name. If provided, this pattern is used instead of the default `^_?resolve$` check. ```
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ts (oxc-project#15978) ~~Draft until we merge oxc-project/schemars#9 and upgrade the oxc-schemars crate in this repo afterwards. Once we have the schemars crate bumped up to 0.8.27 we can safely rebase this branch and this'll be ready to merge.~~ But I can confirm that this now works with my patch to schemars :D Part of oxc-project#14743. Generated docs: ```md ## Configuration This rule accepts a configuration object with the following properties: ### ignore type: `string[]` A list of patterns to ignore when checking `catch` variable names. The pattern can be a string or regular expression. ### name type: `string` default: `"error"` The name to use for error variables in `catch` blocks. You can customize it to something other than `'error'` (e.g., `'exception'`). ``` Unfortunately it doesn't recognize the default value in this case, although I'm not 100% sure why. But at the very least, this works and allows us to finish the docs for most of the remaining lint rules. ```md ## Configuration This rule accepts a configuration object with the following properties: ### rejectPattern type: `[ string, null ]` Regex pattern used to validate the `reject` parameter name. If provided, this pattern is used instead of the default `^_?reject$` check. ### resolvePattern type: `[ string, null ]` Regex pattern used to validate the `resolve` parameter name. If provided, this pattern is used instead of the default `^_?resolve$` check. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's basically just a string anyway.
Merge #8 first.
See also oxc-project/oxc#15978
Resolves oxc-project/oxc#15203