refactor: mark no-unneeded-async-expect-function as vitest compatible#343
Closed
baevm wants to merge 1 commit intooxc-project:mainfrom
Closed
refactor: mark no-unneeded-async-expect-function as vitest compatible#343baevm wants to merge 1 commit intooxc-project:mainfrom
no-unneeded-async-expect-function as vitest compatible#343baevm wants to merge 1 commit intooxc-project:mainfrom
Conversation
Member
|
With #344, this is synced automatically now. So this change will happen automatically once the rule list is updated in the oxc repo. Thanks! |
camchenry
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jan 30, 2026
…m vitest to jest (#18397) this PR moves `no-unneeded-async-expect-function` from vitest to jest plugin and marks it as vitest compatible so it can be used with both the jest and vitest plugins, as discussed [here](#492 (comment)) not sure should i copy all tests from jest, only difference in tests between vitest and jest is this test: ``` import { expect as pleaseExpect } from 'vitest'; it('pass', async () => { await pleaseExpect(doSomethingAsync()).rejects.toThrow(); }) ``` PR to oxlint-migrate: oxc-project/oxlint-migrate#343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR marks
no-unneeded-async-expect-functionas vitest compatible for this PR oxc-project/oxc#18397