Skip to content

chore: oxlint supports ignorePatterns allowlist #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sysix merged 2 commits into from
Sep 5, 2025
Merged

chore: oxlint supports ignorePatterns allowlist #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f36ce7
chore: `oxlint` supports `ignorePatterns` allowlist
Sysix Aug 28, 2025
ca7263a
Merge remote-tracking branch 'origin/main' into chore-oxlint-support-…
Sysix Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions integration_test/__snapshots__/pupeeteer.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,6 @@ exports[`puppeteer > puppeteer 1`] = `
},
},
"warnings": [
"ignore allow list is currently not supported: !.vscode/extensions.json",
"ignore allow list is currently not supported: !.vscode/*.template.json",
"unsupported rule, but in development: import/named",
"unsupported rule: prettier/prettier",
"unsupported rule: spaced-comment",
Expand Down Expand Up @@ -689,8 +687,6 @@ exports[`puppeteer --type-aware > puppeteer--type-aware 1`] = `
},
},
"warnings": [
"ignore allow list is currently not supported: !.vscode/extensions.json",
"ignore allow list is currently not supported: !.vscode/*.template.json",
"unsupported rule, but in development: import/named",
"unsupported rule: prettier/prettier",
"unsupported rule: spaced-comment",
Expand Down Expand Up @@ -1033,8 +1029,6 @@ exports[`puppeteer merge > puppeteer--merge 1`] = `
},
},
"warnings": [
"ignore allow list is currently not supported: !.vscode/extensions.json",
"ignore allow list is currently not supported: !.vscode/*.template.json",
"unsupported rule, but in development: import/named",
"unsupported rule: prettier/prettier",
"unsupported rule: spaced-comment",
Expand Down
3 changes: 0 additions & 3 deletions integration_test/__snapshots__/vscode.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ exports[`vscode > vscode 1`] = `
},
},
"warnings": [
"ignore allow list is currently not supported: !.vscode",
"unsupported rule: constructor-super",
"unsupported rule: prefer-const",
"unsupported rule: no-buffer-constructor",
Expand Down Expand Up @@ -641,7 +640,6 @@ exports[`vscode --type-aware > vscode--type-aware 1`] = `
},
},
"warnings": [
"ignore allow list is currently not supported: !.vscode",
"unsupported rule: constructor-super",
"unsupported rule: prefer-const",
"unsupported rule: no-buffer-constructor",
Expand Down Expand Up @@ -975,7 +973,6 @@ exports[`vscode merge > vscode--merge 1`] = `
},
},
"warnings": [
"ignore allow list is currently not supported: !.vscode",
"unsupported rule: constructor-super",
"unsupported rule: prefer-const",
"unsupported rule: no-buffer-constructor",
Expand Down
10 changes: 0 additions & 10 deletions src/ignorePatterns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,4 @@ export const transformIgnorePatterns = (
targetConfig.ignorePatterns.push(ignores);
}
}

// see https://github.com/oxc-project/oxc/issues/8842
eslintConfig.ignores
.filter((ignore) => ignore.startsWith('!'))
.forEach((ignore) => {
options?.reporter !== undefined &&
options.reporter(
`ignore allow list is currently not supported: ${ignore}`
);
});
};