Skip to content

refactor(linter): add fixer for typescript-eslint/no-non-null-asserted-optional-chain#9993

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_
Mar 24, 2025
Merged

refactor(linter): add fixer for typescript-eslint/no-non-null-asserted-optional-chain#9993
graphite-app[bot] merged 1 commit intomainfrom
03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Mar 23, 2025

Adds fixes for the typescript-eslint/no-non-null-asserted-optional-chain rule in the linter and adds better diagnostic messages with labeled spans.

@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 23, 2025
Copy link
Member Author

camchenry commented Mar 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry marked this pull request as ready for review March 23, 2025 19:18
@camchenry camchenry requested review from Sysix and shulaoda March 23, 2025 19:18
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 23, 2025

CodSpeed Instrumentation Performance Report

Merging #9993 will not alter performance

Comparing 03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_ (ad06194) with main (2d7b0cf)

Summary

✅ 33 untouched benchmarks

@camchenry camchenry force-pushed the fix-empty-diagnostics branch from 56f6a0f to b48e8cc Compare March 24, 2025 02:15
@camchenry camchenry force-pushed the 03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_ branch from 82bce04 to 23c5a68 Compare March 24, 2025 02:15
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Mar 24, 2025
Copy link
Member Author

camchenry commented Mar 24, 2025

Merge activity

  • Mar 23, 10:19 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 23, 10:51 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 23, 10:57 PM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from fix-empty-diagnostics to graphite-base/9993 March 24, 2025 02:25
@graphite-app graphite-app bot force-pushed the graphite-base/9993 branch from b48e8cc to 2d7b0cf Compare March 24, 2025 02:35
@graphite-app graphite-app bot force-pushed the 03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_ branch from 23c5a68 to 4d765e8 Compare March 24, 2025 02:35
@graphite-app graphite-app bot changed the base branch from graphite-base/9993 to main March 24, 2025 02:36
@graphite-app graphite-app bot force-pushed the 03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_ branch from 4d765e8 to cb4a628 Compare March 24, 2025 02:36
…ed-optional-chain` (#9993)

Adds fixes for the `typescript-eslint/no-non-null-asserted-optional-chain` rule in the linter and adds better diagnostic messages with labeled spans.
@graphite-app graphite-app bot force-pushed the 03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_ branch from cb4a628 to ad06194 Compare March 24, 2025 02:51
@graphite-app graphite-app bot merged commit ad06194 into main Mar 24, 2025
29 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 24, 2025
@graphite-app graphite-app bot deleted the 03-23-refactor_linter_add_fixer_for_typescript-eslint_no-non-null-asserted-optional-chain_ branch March 24, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants