Skip to content

ci(vscode): combine jobs #9985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Mar 24, 2025
Merged

ci(vscode): combine jobs #9985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions .github/workflows/ci_vscode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,23 @@ on:
- "pnpm-lock.yaml"
- "crates/oxc_language_server/**"
- "editors/vscode/**"
- ".github/worfkflows/ci_vscode.yml"
- ".github/workflows/ci_vscode.yml"
push:
branches:
- main
paths:
- "pnpm-lock.yaml"
- "crates/oxc_language_server/**"
- "editors/vscode/**"
- ".github/worfkflows/ci_vscode.yml"
- ".github/workflows/ci_vscode.yml"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
cancel-in-progress: ${{ github.ref_name != 'main' }}

jobs:
compile:
name: Compile
runs-on: ubuntu-latest
steps:
- uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
- uses: ./.github/actions/pnpm

- name: Compile VSCode
working-directory: editors/vscode
run: pnpm run compile

lint:
name: Lint
name: Lint & Typecheck
runs-on: ubuntu-latest
steps:
- uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
Expand All @@ -47,13 +36,6 @@ jobs:
working-directory: editors/vscode
run: pnpm run lint

type-check:
name: Type-Check
runs-on: ubuntu-latest
steps:
- uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
- uses: ./.github/actions/pnpm

- name: Type-Check VSCode
working-directory: editors/vscode
run: pnpm run type-check
Expand All @@ -65,9 +47,13 @@ jobs:
- uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
- uses: ./.github/actions/pnpm

- name: Build
- name: Build Language Server
working-directory: editors/vscode
run: pnpm run build
run: pnpm run server:build:release

- name: Compile VSCode
working-directory: editors/vscode
run: pnpm run compile

- name: Test VSCode
working-directory: editors/vscode
Expand Down