Skip to content

test(editor): add tests for offset_to_position#9978

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-22-test_editor_add_tests_for_offset_to_position_
Mar 23, 2025
Merged

test(editor): add tests for offset_to_position#9978
graphite-app[bot] merged 1 commit intomainfrom
03-22-test_editor_add_tests_for_offset_to_position_

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Mar 23, 2025

Working on adding more comprehensive tests for the LSP code. This offset to position function is a core part of the range calculations, so we should start to have some tests for it.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Mar 23, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry marked this pull request as ready for review March 23, 2025 02:00
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 23, 2025

CodSpeed Instrumentation Performance Report

Merging #9978 will not alter performance

Comparing 03-22-test_editor_add_tests_for_offset_to_position_ (c2f1be0) with main (6c4b533)

Summary

✅ 33 untouched benchmarks

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Mar 23, 2025
Copy link
Member Author

camchenry commented Mar 23, 2025

Merge activity

  • Mar 22, 10:52 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 22, 10:52 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 22, 10:58 PM EDT: A user merged this pull request with the Graphite merge queue.

Working on adding more comprehensive tests for the LSP code. This offset to position function is a core part of the range calculations, so we should start to have some tests for it.
@graphite-app graphite-app bot force-pushed the 03-22-test_editor_add_tests_for_offset_to_position_ branch from c70ec35 to c2f1be0 Compare March 23, 2025 02:52
@graphite-app graphite-app bot merged commit c2f1be0 into main Mar 23, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 03-22-test_editor_add_tests_for_offset_to_position_ branch March 23, 2025 02:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants