Skip to content

refactor(linter): improve eslint/no-redeclare#9976

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-23-fix/eslint-no-redeclare
Mar 23, 2025
Merged

refactor(linter): improve eslint/no-redeclare#9976
graphite-app[bot] merged 1 commit intomainfrom
03-23-fix/eslint-no-redeclare

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Mar 22, 2025 •
edited
Loading

Related to #8237

  • Improve the documentation
  • Align diagnostic format with eslint
  • Fix errors exposed after adding test cases

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@shulaoda shulaoda requested review from Sysix, camc314 and camchenry March 22, 2025 18:59
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 22, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 22, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #9976 will not alter performance

Comparing 03-23-fix/eslint-no-redeclare (402d8b7) with main (ff13be6)

Summary

✅ 33 untouched benchmarks

camchenry
camchenry approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of like showing the prior definition on the lint rule, but this is probably faster and aligned with ESLint I suppose

Sysix
Sysix reviewed Mar 22, 2025
View reviewed changes
Copy link
Member

@Sysix Sysix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the old diagnostic more too.

builtinGlobals should only look for following globals:
https://github.com/oxc-project/javascript-globals/blob/979277eeecf707f77ca7a5fd5ee55d3eef34fed5/src/lib.rs#L10-L72

@shulaoda shulaoda requested review from Sysix and camchenry March 23, 2025 00:58
@shulaoda shulaoda added the 0-merge Merge with Graphite Merge Queue label Mar 23, 2025
@shulaoda Graphite App
Copy link
Contributor Author

shulaoda commented Mar 23, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 22, 9:17 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 22, 9:17 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 22, 9:23 PM EDT: A user merged this pull request with the Graphite merge queue.

@shulaoda
refactor(linter): improve eslint/no-redeclare (#9976)
402d8b7 
Related to #8237

- Improve the documentation
- ~~Align diagnostic format with `eslint`~~
- Fix errors exposed after adding test cases
@graphite-app graphite-app bot force-pushed the 03-23-fix/eslint-no-redeclare branch from 2f9183a to 402d8b7 Compare March 23, 2025 01:18
@graphite-app graphite-app bot merged commit 402d8b7 into main Mar 23, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 03-23-fix/eslint-no-redeclare branch March 23, 2025 01:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 23, 2025
@oxc-bot oxc-bot mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sysix Sysix Sysix approved these changes

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

@camchenry camchenry Awaiting requested review from camchenry

Assignees

No one assigned

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shulaoda @camchenry @Sysix